Feat: stopping criteria for solvers#690
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PyLops's solvers tend to lack stopping criteria or have one/two simple stopping criterion directly implemented as part of the
whilestatement in therunmethod (with one of them always being the max number of iterations).This PR aims to introduce additional stopping criteria. However instead of adding them directly to the
whilestatement , those are implemented as specialcallbackswith astopmember.For the moment, only one of such stopping criterion is implemented based on the ratio between the initial and current residual norm or total cost function (
ResidualNormCallback) and is added to all solvers that have acostinternal member tracking the history of the residual norm or total cost function.Definition of done
ResidualNormCallbackand stopping auxiliary routine_callback_stop